-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Add support for custom Octicons in admin nav sections #4382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hey there, I'd love to know if a merge is planned for this. This functionality would be great!
1 task
DaTebe
commented
Sep 19, 2018
I would also like to see this feature
Norbz
commented
Nov 20, 2018
Once again, a small but usefull feature dead in its tracks because of no one validating PR...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
This pull request adds support for the ability to specify custom icon classes to associate with Admin UI nav sections, i.e. those configured by
keystone.set('nav', ...).I proposed this feature not too long ago but didn't realize then what an easy change it would be (the feature is basically already "built in" and just needed a tweak to "enable" it).
To use this feature, instead of writing
you can instead write
which will override the default 'bullet' icon. All previous behaviours are left intact (bullet is still default if no icon provided, component still "auto-selects" an icon based on list name).
The auto-selecting behaviour struck me as a bit presumptuous; this pull request hopes to address that by opening it up completely.
Might deal with #3505.