Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add support for custom Octicons in admin nav sections #4382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wosevision wants to merge 1 commit into keystonejs:master
base: master
Choose a base branch
Loading
from wosevision:nav-icon-support

Conversation

@wosevision
Copy link

@wosevision wosevision commented Jul 5, 2017
edited
Loading

This pull request adds support for the ability to specify custom icon classes to associate with Admin UI nav sections, i.e. those configured by keystone.set('nav', ...).

I proposed this feature not too long ago but didn't realize then what an easy change it would be (the feature is basically already "built in" and just needed a tweak to "enable" it).

To use this feature, instead of writing

keystone.set('nav', {
 'small animals': ['mice', 'rats']
});

you can instead write

keystone.set('nav', {
 'small animals': {
 lists: ['mice', 'rats'],
 icon: 'octicon octicon-squirrel'
});

which will override the default 'bullet' icon. All previous behaviours are left intact (bullet is still default if no icon provided, component still "auto-selects" an icon based on list name).

The auto-selecting behaviour struck me as a bit presumptuous; this pull request hopes to address that by opening it up completely.

Might deal with #3505.

alobodig, eibbors, kmiddlesworth, alifgiant, and Twansparant reacted with thumbs up emoji
Copy link

kmiddlesworth commented Oct 30, 2017
edited
Loading

Hey there, I'd love to know if a merge is planned for this. This functionality would be great!

alifgiant, Twansparant, and DaTebe reacted with thumbs up emoji

Copy link

DaTebe commented Sep 19, 2018

I would also like to see this feature

Copy link

Norbz commented Nov 20, 2018

Once again, a small but usefull feature dead in its tracks because of no one validating PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /