-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat (admin ui custom field): extend keystone field with application custom field #3313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Woah this is an awesome PR @phucpnt!
We're definitely going to work on admin interface extensibility, but I think that these specific changes are too small in scope. We don't just want you to be able to add custom fields, we want you to be able to completely customize every part of it! This means I can't guarantee we'll land this as-is, but this is an amazing PR with tests and everything! 👏
Going to defer to @JedWatson for the final call on if we want to merge this?
thanks @mxstbr !
I enjoy using keystone, the admin field UI mechanism is well established. It would be awesome for me if keystone have an extendable field ui. I hope the small updates will give provide some level flexibility for keystone.
Let me know @JedWatson
Description of changes
Extend keystone admin UI field with custom field defined by application.
Related issues (if any)
Testing
createStaticRouternpm run test-allran successfully.