Search code, repositories, users, issues, pull requests...

Copy link

Member

@Sarthak160 Sarthak160 commented Mar 3, 2024

Related Issue

Info about Issue or bug

Closes: #[issue number that will be closed through this PR]

Describe the changes you've made

A clear and concise description of what you have done to successfully close your assigned issue. Any new files? or anything you feel to let us know!

Type of change

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Code style update (formatting, local variables)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How did you test your code changes?

Please describe the tests(if any). Provide instructions how its affecting the coverage.

Describe if there is any unusual behaviour of your code(Write `NA` if there isn't)

A clear and concise description of it.

Checklist:

My code follows the style guidelines of this project.
I have performed a self-review of my own code.
I have commented my code, particularly in hard-to-understand areas and used java doc.
I have made corresponding changes to the documentation.
My changes generate no new warnings.
I have added tests that prove my fix is effective or that my feature works.
New and existing unit tests pass locally with my changes.

Screenshots (if any)

Original	Updated
original screenshot	updated screenshot


 feat: assert and fail mvn test if the keploy test fails

f5d21f6

Signed-off-by: Sarthak160 <rocksarthak45@gmail.com>

@Sarthak160 Sarthak160 requested a review from gouravkrosx

March 3, 2024 20:13

github-actions[bot]

github-actions bot reviewed

Mar 3, 2024

View reviewed changes

pom.xml

</execution>

</executions>

</plugin>

Copy link

@github-actions github-actions bot Mar 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineCheck> _{reported by reviewdog 🐶}
Line has trailing spaces.

v2/src/main/java/io/keploy/Keploy.java Outdated

private static String jacocoCliPath = "";

privatestaticStringcurrentTestRunId;

Copy link

@github-actions github-actions bot Mar 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

v2/src/main/java/io/keploy/Keploy.java Outdated

stopUserApplication();

}

logger.debug("All test sets executed and stoping the ebpf hooks" );

logger.debug("All test sets executed and stopping the ebpf hooks" );

Copy link

@github-actions github-actions bot Mar 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.whitespace.ParenPadCheck> _{reported by reviewdog 🐶}
')' is preceded with whitespace.

}

} catch (InterruptedException e) {

System.err.println("Error waiting for test run completion: " + e.getMessage());

logger.error("Error waiting for test run completion: " + e.getMessage());

Copy link

@github-actions github-actions bot Mar 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 80 characters (found 85).


 refactor: fail if even one test set fails

c17f832

Signed-off-by: Sarthak160 <rocksarthak45@gmail.com>

github-actions[bot]

github-actions bot reviewed

Mar 4, 2024

View reviewed changes

private static String jacocoCliPath = "";

privatestaticStringcurrentTestRunId;

Copy link

@github-actions github-actions bot Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

privatestaticStringcurrentTestRunId;

private static String jacocoAgentPath = "";

private static Boolean isFailed = false;

Copy link

@github-actions github-actions bot Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

privatestaticStringcurrentTestRunId;

private static String jacocoAgentPath = "";

private static Boolean isFailed = false;

private static List<String> failedTestSets = new ArrayList<>();

Copy link

@github-actions github-actions bot Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocVariableCheck> _{reported by reviewdog 🐶}
Missing a Javadoc comment.

private static String jacocoAgentPath = "";

private static Boolean isFailed = false;

private static List<String> failedTestSets = new ArrayList<>();

Copy link

@github-actions github-actions bot Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineCheck> _{reported by reviewdog 🐶}
Line has trailing spaces.

// Check the test run status after all tests are executed

// change to each test run and at last if any of the test failed then throw an

Copy link

@github-actions github-actions bot Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 80 characters (found 86).

// TestRunStatus status = FetchTestSetStatus(currentTestRunId);

// Throw an exception if the status is FAILED

if (isFailed) {

org.junit.jupiter.api.Assertions.fail("Test run failed for test sets : " + failedTestSets);

Copy link

@github-actions github-actions bot Mar 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> _{reported by reviewdog 🐶}
Line is longer than 80 characters (found 103).

Copy link

Member Author

Sarthak160 commented Mar 4, 2024

@gouravkrosx Please run this once at your end, So that I can merge and release .


 refactor: remove print statement

Signed-off-by: Sarthak160 <rocksarthak45@gmail.com>

github-actions[bot]

github-actions bot reviewed

Mar 5, 2024

View reviewed changes

logger.info("Test run failed");

isFailed = true;

failedTestSets.add(currentTestRunId);

Copy link

@github-actions github-actions bot Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineCheck> _{reported by reviewdog 🐶}
Line has trailing spaces.

Copy link

keploy-staging bot commented Apr 14, 2025

⚠️ Oops! We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

8 similar comments

Copy link

keploy-staging bot commented Apr 14, 2025

⚠️ Oops! We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

Copy link

keploy-staging bot commented Apr 14, 2025

⚠️ Oops! We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

Copy link

keploy-staging bot commented Apr 14, 2025

⚠️ Oops! We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

Copy link

keploy-staging bot commented Apr 14, 2025

⚠️ Oops! We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

Copy link

keploy-staging bot commented Apr 14, 2025

⚠️ Oops! We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

Copy link

keploy-staging bot commented Apr 14, 2025

⚠️ Oops! We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

Copy link

keploy-staging bot commented Apr 14, 2025

⚠️ Oops! We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

Copy link

keploy-staging bot commented Apr 14, 2025

⚠️ Oops! We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

Copy link

keploy-staging bot commented Apr 14, 2025 •

edited

Loading

Nice Pr 😄. We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

3 similar comments

Copy link

keploy-staging bot commented Apr 14, 2025

Nice Pr 😄. We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

Copy link

keploy-staging bot commented Apr 14, 2025

Nice Pr 😄. We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

@keploy

Copy link

keploy bot commented Apr 15, 2025 •

edited

Loading

Nice Pr 😄. We currently support Unit Test Generation only for Go projects.
Stay tuned – support for more languages is coming soon! 🚀

Labels

None yet

1 participant