-
Notifications
You must be signed in to change notification settings - Fork 690
Fix parsing of query field of RowsQueryEvent #602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parsing of query field of RowsQueryEvent #602
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
except reivew LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about delete line#875
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
except fix lint
This also crashes for our MySQL 8.035. Would love to see it merged in. We are having to use: poetry add git+ssh://git@github.com:dongwook-chan/python-mysql-replication.git
Uh oh!
There was an error while loading. Please reload this page.
Description
The first byte of payload in RowsQueryEvent must be ignored without being used as the length for the following field
query. Yet, the existing code did use this value as length forqueryand fails whenever parsing query longer than 255 characters which is the maximum value that a single byte can hold.I fixed the bug referring to code from msql-server.
Other clients in different languages implement the RowsQueryEvent the way mysql-server does and noted below as references.
Type of Change
Checklist
Tests
Additional Information