-
Couldn't load subscription status.
- Fork 690
test dump method in test_delete_row_event #592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
roy0424
wants to merge
2
commits into
julien-duponchelle:main
from
roy0424:test/test-delete-row-event
Closed
test dump method in test_delete_row_event #592
roy0424
wants to merge
2
commits into
julien-duponchelle:main
from
roy0424:test/test-delete-row-event
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@roy0424
The user var event is the user entering the value directly, so I think the mock test makes sense, but the
I don't understand why the delete event generates a separate mock event.
I think this is just comparing the same IO occurrences.
Is there any particular reason?
@sean-k1 I made it to improve coverage. But I realized that this test was unnecessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
Description
Type of Change
Checklist
Tests
Additional Information