-
Couldn't load subscription status.
- Fork 690
refactor: check 'is_mariadb' when trying to set 'mariadb-related variable(mariadb_slave_capability)' to master #559
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ebang091
wants to merge
3
commits into
julien-duponchelle:main
from
python-mysql-replication-kr:refactor-BinlogStreamReader
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongwook-chan
dongwook-chan
requested changes
Oct 16, 2023
dongwook-chan
dongwook-chan
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for helping the project be more Pythonic!
sean-k1
sean-k1
approved these changes
Oct 17, 2023
Because not all tests were functional at the point of this PR.
I will run some tests manually before merging this to main.
Could you wait just a bit more?
@dongwook-chan
dongwook-chan
added
hacktoberfest-accepted
and removed
hacktoberfest
labels
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thought codes below needs check whether the master is mariaDB or not.
before
Screen Shot 2023年10月16日 at 11 56 35 PMafter
Screen Shot 2023年10月16日 at 11 56 07 PM