Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Boolean operators are boolean operators #992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
handrews wants to merge 1 commit into json-schema-org:master from handrews:bool

Conversation

@handrews
Copy link
Contributor

@handrews handrews commented Sep 16, 2020

This has been reported as a point of confusion.

Fixes #910

This has been reported as a point of confusion.
Copy link
Member

I don't have any problems with the PR, although I'm not familiar with those terms.
I wasn't convinced the associated issue actually required any changes.
I still feel like the words we have were enough to convey the requirements, but we didn't get a subsequent response from @gregsdennis on the issue.

Copy link
Contributor Author

Copy link
Member

Yeah. I mean I used google and they made sense. I obviously didn't study that aspect of maths I guess.

Copy link
Contributor Author

@Relequestual to be fair, the grammatical forms commutativity and associativity are probably not the most recognizable forms. But they do come up easily in a google search and I like that they are precisely defined.

Relequestual reacted with laugh emoji

Copy link
Member

I don't think associativity is needed. It describes how terms are grouped, but subschemas aren't grouped at all within a *Of, they're just listed.

Commutativity (ordering of terms) should be sufficient.

Copy link
Contributor Author

I still don't even understand why I have to explain commutativity so I'd rather just cover all the bases I guess.

Copy link
Member

For reference:

Associativity:

(a + b) + c = a + (b + c)

Commutativity:

a + b = b + a

Copy link
Member

@gregsdennis FYI still waiting to hear re: #910 (comment)

Copy link
Contributor Author

@gregsdennis FYI still waiting to hear re: #910 (comment)

Yeah I'm also happy to just drop this PR.

What I don't want to do is write something that facilitates the expectation that things are ordered unless explicitly stated otherwise. These are boolean operators. They act like boolean operators and that's more important than JSON syntax.

Copy link
Member

Happy to drop

Copy link
Contributor Author

@gregsdennis cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Relequestual Relequestual Awaiting requested review from Relequestual

@gregsdennis gregsdennis Awaiting requested review from gregsdennis

Assignees

No one assigned

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Section 9.2.1 (*Of keywords) is non-specific about sequencing

AltStyle によって変換されたページ (->オリジナル) /