- 
 
- 
  Notifications
 You must be signed in to change notification settings 
- Fork 357
Boolean operators are boolean operators #992
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This has been reported as a point of confusion.
I don't have any problems with the PR, although I'm not familiar with those terms.
I wasn't convinced the associated issue actually required any changes.
I still feel like the words we have were enough to convey the requirements, but we didn't get a subsequent response from @gregsdennis on the issue.
@Relequestual which terms- commutativity and associativity?
https://en.wikipedia.org/wiki/Commutative_property 
https://en.wikipedia.org/wiki/Associative_property 
Yeah. I mean I used google and they made sense. I obviously didn't study that aspect of maths I guess.
@Relequestual to be fair, the grammatical forms commutativity and associativity are probably not the most recognizable forms. But they do come up easily in a google search and I like that they are precisely defined.
I don't think associativity is needed. It describes how terms are grouped, but subschemas aren't grouped at all within a *Of, they're just listed.
Commutativity (ordering of terms) should be sufficient.
I still don't even understand why I have to explain commutativity so I'd rather just cover all the bases I guess.
For reference:
Associativity:
(a + b) + c = a + (b + c)
Commutativity:
a + b = b + a
@gregsdennis FYI still waiting to hear re: #910 (comment)
@gregsdennis FYI still waiting to hear re: #910 (comment)
Yeah I'm also happy to just drop this PR.
What I don't want to do is write something that facilitates the expectation that things are ordered unless explicitly stated otherwise. These are boolean operators. They act like boolean operators and that's more important than JSON syntax.
Happy to drop
@gregsdennis cool, thanks!
This has been reported as a point of confusion.
Fixes #910