Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[suggestion] don't link vocabulary URIs; they are not retrievable #874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
handrews merged 1 commit into json-schema-org:master from notEthan:vocablink
May 15, 2020

Conversation

@notEthan
Copy link
Contributor

@notEthan notEthan commented Mar 8, 2020

it doesn't seem to me to make sense that these are links. there is no document to retrieve. if you follow the link, it just links back to the same sections of the spec the link came from.

Copy link
Contributor

What if you are reading on a copied / cached / reformatted version of the spec?

Copy link
Contributor Author

notEthan commented Mar 8, 2020

I'm not sure I quite understand the question?

I expect this would go in the next draft of the spec (if agreed upon), since 2019-09 is already released, and not actually have the IDs in this PR - I would have PR'd on a branch for the next draft if I saw one.

Copy link
Contributor

handrews commented Apr 7, 2020

@notEthan there's no branch, we do the regular work on master, and branch for things like meta-schema bugfixes. As you noted, there's no way to update a published RFC anyway, so there's no point in a branch on that.

This is a reasonable idea. @philsturgeon @gregsdennis as people working on tools supporting this, what do you think of this one? Also paging @Relequestual on general principle.

Copy link
Member

Agreed. I'll leave others to comment. This sounds reasonable.

Copy link
Contributor Author

notEthan commented Apr 8, 2020

I don't think this change would affect any tools. it should only affect how the spec appears to humans reading it - whether the URI is linked or not.

jdesrosiers reacted with thumbs up emoji

Copy link
Contributor

handrews commented Apr 8, 2020

Note that we do plan to eventually have files here, and could backport them to older drafts, so that is actually a fairly strong reason to leave them as links. You can't go back and change them once published, so a backport would only work if they were published as links.

On the other hand, you could still copy-paste them, I suppose, but it's less obvious.

@handrews handrews merged commit 0c1b6fc into json-schema-org:master May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Relequestual Relequestual Relequestual approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /