-
-
Couldn't load subscription status.
- Fork 358
Split "requiredDependencies" out of "dependencies" #573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"dependencies", with the schema behavior, moves to the validation spec with the other applicators. "requiredDependencies", with the property array behavior, stays in validation as an assertion alongside "required"
jsonschema-validation.xml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this sentence is useful considering the one that follows (in fact, I cannot easily read it (but maybe it's because I'm not native English)). Also, most keyword's description start out by "The value of this keyword MUST be ..." so this one would be (is already) an exception with this sentence. Not a big deal, though :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good points, let me see if I can rework it to be more consistent and clear.
Use language based on a combination of "required" and "properties", and make the simple description (the 2nd paragraph) more clear.
@dlax how does this version look?
Looks good 👍
"dependencies", with the schema behavior, moves to the validation
spec with the other applicators. "requiredDependencies", with
the property array behavior, stays in validation as an assertion
alongside "required"