-
-
Notifications
You must be signed in to change notification settings - Fork 358
Update markdown list item lint rule #1550
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
jdesrosiers
wants to merge
1
commit into
json-schema-org:main
from
jdesrosiers:update-md-list-item-lint
Closed
Update markdown list item lint rule #1550
jdesrosiers
wants to merge
1
commit into
json-schema-org:main
from
jdesrosiers:update-md-list-item-lint
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jdesrosiers
jdesrosiers
force-pushed
the
update-md-list-item-lint
branch
from
October 22, 2024 22:20
c1d7404 to
e75ff69
Compare
gregsdennis
gregsdennis
approved these changes
Oct 22, 2024
Let's leave open for two-ish days to see if anyone has an issue with it, but I think it can be merged early.
@jdesrosiers I just realized that drafts don't alert people. Going to leave open for another couple days then merge. Let me know if you wanted to change something else here.
Obsoleted by #1554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gregsdennis and I weren't a fan of the default markdown list-item linting rule. See, https://cirosantilli.com/markdown-style-guide/#spaces-after-list-marker for details. The default is "mixed". We prefer "one".