-
-
Notifications
You must be signed in to change notification settings - Fork 357
remove 'mathematical integers' section #1437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per #898 (comment)
I agree, I don't think JSON encoding is within scope of the JSON Schema spec.
PR can be merged after Fri Sep 22 2023 05:45:26 GMT+0000 (Coordinated Universal Time)
It has now passed this date - any chance we can get this merged? It's causing me some problems.
I realised after the fact this was just a doc update. Apologies for the confusion
Merging the PR isn't going to help in the near term any. This is merging into an unpublished document.
If you like, come join us in slack or start a discussion in the community repo and we can help you with out your problem.
I'll review and merge in the morning.
I just noticed when building the spec to review another change that removing this section caused a couple broken links.
> @json-schema-org/json-schema-spec@1.0.0 build-core
> node build/build.js < jsonschema-core.md > jsonschema-core.html
2757:1-2757:17 warning Link to unknown heading: `integers` missing-heading remark-validate-links
2778:1-2778:17 warning Link to unknown heading: `integers` missing-heading remark-validate-links
Resolves #898
After wordsmithing something that sounded approximately right, I found Instance Equality, which pretty much clears up any debate in my mind.