Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Pr automation #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gregsdennis wants to merge 19 commits into main from pr-automation
Closed

Pr automation #1072

gregsdennis wants to merge 19 commits into main from pr-automation

Conversation

@gregsdennis
Copy link
Member

@gregsdennis gregsdennis commented Feb 1, 2021
edited
Loading

Resolves #1069
Relates to #1070 & #1071

Happy to take opinions on the content of 👇. It all works pretty well, though, so I don't think I'll be changing the mechanics.


gregsdennis and Afshin4030 reacted with hooray emoji
Copy link
Member Author

gregsdennis commented Feb 1, 2021
edited
Loading

adding checklist looks 👍

working on enforcing next...

@gregsdennis gregsdennis added this to the draft-next milestone Feb 1, 2021
Copy link
Member

can you summarize what these checklists entail, for those of us who haven't learned github workflows yet? :)

Copy link
Member Author

There's some discussion in #1069 around it. It's basically a guide or reminder.

  • Not having all the items checked will fail the build, but it won't prevent merging.
  • The build doesn't auto-run when the opening comment changes, so it'll need to be re-run manually.
  • It's not really enforcement since items can be removed or falsely checked.

Copy link
Member

Honestly, I think this work is a bit premature. Our process should be discussed, agreed upon, and documented in CONTRIBUTING.md before we automate it. Having an assigned milestone and a test suite issue are requirements (recommendations?) that are not currently documented. Linking an issue is only mentioned as something that should be done if there is an issue that the PR resolves. Let's start by documenting what we want, then add automation where it makes sense.

Copy link
Member Author

As I mentioned above, there has been some discussion in issues as well as in Slack, but if you'd like official docs first that's fine. I don't think this will go stale or conflict with anything.

Copy link
Member

Honestly, I think this work is a bit premature. Our process should be discussed, agreed upon, and documented in CONTRIBUTING.md before we automate it. Having an assigned milestone and a test suite issue are requirements (recommendations?) that are not currently documented. Linking an issue is only mentioned as something that should be done if there is an issue that the PR resolves. Let's start by documenting what we want, then add automation where it makes sense. - @jdesrosiers

I think I'd have to agree. I'm doing some work this week on community things so let's see how we go.

1050880

This comment was marked as spam.

Copy link
Contributor

@gregsdennis given the concerns from @jdesrosiers and @Relequestual (with which I think I agree), can this be closed in favor of a discussion somewhere?

Copy link
Member Author

There's already discussion elsewhere, as noted in the opening comment.

This PR isn't doing any harm just sitting here. This kind of automation is still something I'd like to see. It relates to repo management, like requiring an approval, which we did a few weeks ago; it's a nice to have. The only reason it's still open is that people have forgotten about it.

handrews reacted with thumbs up emoji

Copy link
Member Author

I also discovered that actions can trigger from comment changes, so I might add that.

Copy link
Member Author

Closing per #1069 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdesrosiers jdesrosiers Awaiting requested review from jdesrosiers

@karenetheridge karenetheridge Awaiting requested review from karenetheridge

@Relequestual Relequestual Awaiting requested review from Relequestual

@ssilverman ssilverman Awaiting requested review from ssilverman

1 more reviewer

@1050880 1050880 1050880 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

draft-next

Development

Successfully merging this pull request may close these issues.

Automate some of the PR things

AltStyle によって変換されたページ (->オリジナル) /