-
Notifications
You must be signed in to change notification settings - Fork 156
Update Scroll Container in Controller #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jscottsmith
merged 1 commit into
master
from
feature/update-scroll-container-in-controller
Apr 7, 2019
Merged
Update Scroll Container in Controller #57
jscottsmith
merged 1 commit into
master
from
feature/update-scroll-container-in-controller
Apr 7, 2019
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #57 +/- ## ========================================= - Coverage 91.75% 90.65% -1.1% ========================================= Files 26 26 Lines 279 289 +10 Branches 46 47 +1 ========================================= + Hits 256 262 +6 - Misses 18 23 +5 + Partials 5 4 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the controller scroll container in the ParallaxProvider when the element updates. See #56