Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Update ParallaxController.js #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bartlomiejzuber wants to merge 7 commits into jscottsmith:master from bartlomiejzuber:master

Conversation

@bartlomiejzuber
Copy link

@bartlomiejzuber bartlomiejzuber commented Nov 9, 2018

Top and bottom positions are wrong calculated with slowerScrollRate flag set to off.

top and bottom positions calculation fix when slowerScrollRate is off
Copy link

codecov-io commented Nov 9, 2018
edited
Loading

Codecov Report

Merging #43 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@ Coverage Diff @@
## master #43 +/- ##
=======================================
 Coverage 94.76% 94.76% 
=======================================
 Files 11 11 
 Lines 210 210 
 Branches 45 45 
=======================================
 Hits 199 199 
 Misses 10 10 
 Partials 1 1
Impacted Files Coverage Δ
src/libs/ParallaxController.js 91.59% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bc2b3b...fa0893e. Read the comment docs.

Copy link
Owner

Thanks but this is intentional behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /