-
Notifications
You must be signed in to change notification settings - Fork 69
feat: adding problem title to commit message #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for the contribution @matheusaraujo! Apologies in the delay in reviewing, but I think this looks great for now. If other users decide they want more flexibility in the commit message, that could be an additional feature added later - will go ahead and merge this.
Great, @joshcai! Thanks for the update!
Do you already know when a new release will be created?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey guys, first of all, really nice job here! 👏 I'm using and loving it! 🚀
There's only one little thing that, in my opinion, could be improved: include the problem title on the commit message, it would make easier to find the problem on git history.
I've made this simple change to achieve it.
But since this is a very personal preference, I believe a more generic solution would be better.
My idea is having an input variable
commit-message-templatereplacing the existingcommit-header.On this variable the pre-defined available infos could be defined using a template string, the default value could be exact like
[LeetCode Sync] - Runtime - ${submission.runtime} (${submission.runtimePerc}), Memory - ${submission.memory} (${submission.memoryPerc}), keeping the current behavior, but also improving the flexibility.I haven't implemented yet just because of time, the current forked works well for me. But, if you guys also believes that this is a good idea, I can try to implement it!