-
Notifications
You must be signed in to change notification settings - Fork 69
Fix for fetching submission info when runtime or memory percentile is null #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@jaspinderkohli
jaspinderkohli
changed the title
(削除) Fix for fetching submission info when runtime or memory percentile when was null (削除ここまで)
(追記) Fix for fetching submission info when runtime or memory percentile is null (追記ここまで)
Jun 24, 2024
Thank you for the fix and the detailed PR description! LGTM so will merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for fetching submission info when runtime or memory percentile is null
Description
This pull request addresses an issue where fetching submission info results in a
TypeErrorwhen either the runtime or memory percentile isnull. The error occurs because thetoFixedmethod is called on anullvalue, causing the script to crash.Issue
The issue was reported in the following error message:
Root Cause
The root cause of this issue is that the
getInfofunction does not correctly handle cases where theruntimePercentileormemoryPercentileproperties arenull. When these values arenull, calling thetoFixedmethod on them results in aTypeError.Fix
The fix involves adding a check to ensure that the
runtimePercentileandmemoryPercentileproperties are notnullorundefinedbefore calling thetoFixedmethod. If these properties arenullorundefined, the function will return "N/A" instead.Addresses
This fix addresses issue #58