Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix for fetching submission info when runtime or memory percentile is null #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshcai merged 8 commits into joshcai:master from jaspinderkohli:master
Jun 24, 2024

Conversation

@jaspinderkohli
Copy link
Contributor

@jaspinderkohli jaspinderkohli commented Jun 24, 2024

Fix for fetching submission info when runtime or memory percentile is null

Description

This pull request addresses an issue where fetching submission info results in a TypeError when either the runtime or memory percentile is null. The error occurs because the toFixed method is called on a null value, causing the script to crash.

Issue

The issue was reported in the following error message:

Root Cause

The root cause of this issue is that the getInfo function does not correctly handle cases where the runtimePercentile or memoryPercentile properties are null. When these values are null, calling the toFixed method on them results in a TypeError.

Fix

The fix involves adding a check to ensure that the runtimePercentile and memoryPercentile properties are not null or undefined before calling the toFixed method. If these properties are null or undefined, the function will return "N/A" instead.

Addresses

This fix addresses issue #58

@jaspinderkohli jaspinderkohli changed the title (削除) Fix for fetching submission info when runtime or memory percentile when was null (削除ここまで) (追記) Fix for fetching submission info when runtime or memory percentile is null (追記ここまで) Jun 24, 2024
Copy link
Owner

joshcai commented Jun 24, 2024

Thank you for the fix and the detailed PR description! LGTM so will merge.

jaspinderkohli reacted with heart emoji

@joshcai joshcai merged commit 77d3da7 into joshcai:master Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /