Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Added Problem data with solution at the end, changed file type to mar... #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshcai merged 3 commits into joshcai:master from jaspinderkohli:feature/add-question-data
Aug 18, 2023

Conversation

@jaspinderkohli
Copy link
Contributor

@jaspinderkohli jaspinderkohli commented Jul 18, 2023
edited
Loading

Description

This PR adds the feature to retrieve and display question data in the project.

Changes Made

  • Implemented the functionality to fetch question data from the GraphQL API.
  • Integrated the retrieved question data into the existing codebase.
  • Displayed the question content appropriately.
  • UPDATE: There's a separate file now for question data i.e question.md and solution solution.lang_extension

Reason for the Feature

The addition of problem description enhances the project by providing more comprehensive information about each solution.

Screenshots

Here's the updated code that creates a separate 'question.md' file for the question data:

Question File

Additionally, we now have individual solution files with the language as their extension:

Solution File

Feel free to share any other suggestions you might have!

Please review this PR at your convenience. Your feedback and suggestions are highly appreciated.

Also, Thank you for building this awesome action.

Copy link
Owner

@joshcai joshcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for this awesome feature! Left some comments and apologies for the delay in reviewing.

jaspinderkohli reacted with heart emoji
@joshcai joshcai merged commit f62f2bf into joshcai:master Aug 18, 2023
Copy link
Owner

joshcai commented Aug 18, 2023

Looks great now, thank you! Apologies for the delayed review.

jaspinderkohli reacted with hooray emoji

@jaspinderkohli jaspinderkohli deleted the feature/add-question-data branch August 18, 2023 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshcai joshcai Awaiting requested review from joshcai

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /