Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Ability to disable JinjaCpp installation rules #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rmorozov merged 2 commits into jinja2cpp:master from ilya-lavrenov:jinja-installation-rules
May 24, 2024

Conversation

@ilya-lavrenov
Copy link
Contributor

@ilya-lavrenov ilya-lavrenov commented May 10, 2024 •
edited
Loading

  • When JinjaCpp is build as sub-project and used as static library, installation rules are not required. It's a good practice to disable installation rules when project is used as a subproject.
  • Secondly, cloning of boost repository takes a while, while download archive is more compact and fast way.
  • Migrated to new 1.85 boost version, which does not require patching

Copy link
Contributor Author

Hi @rmorozov
Could you please review?

Copy link
Member

@ilya-lavrenov , sure, could you please fix CI errors?

If you don't have access to info about errors - let me know.

Copy link
Contributor Author

@ilya-lavrenov , sure, could you please fix CI errors?

If you don't have access to info about errors - let me know.

I've experienced the same error locally even w/o my changes.

Is it possible to run CI on latest master to confirm it?

Copy link
Member

@ilya-lavrenov , sure, could you please fix CI errors?
If you don't have access to info about errors - let me know.

I've experienced the same error locally even w/o my changes.

Is it possible to run CI on latest master to confirm it?

@ilya-lavrenov , sure, I have run it on #251

CI is green, so it seems that error connected with new changes in this PR

Copy link
Contributor Author

Hi @rmorozov
I've updated the branch. Could you please run CI?
rmorozov reacted with thumbs up emoji

Copy link
Member

@ilya-lavrenov , Seems fine now

thank you for your effort
ilya-lavrenov reacted with hooray emoji

@rmorozov rmorozov merged commit 9ae7e1f into jinja2cpp:master May 24, 2024
@ilya-lavrenov ilya-lavrenov deleted the jinja-installation-rules branch May 24, 2024 14:59
@ilya-lavrenov ilya-lavrenov restored the jinja-installation-rules branch May 24, 2024 14:59
atobiszei added a commit to atobiszei/Jinja2Cpp that referenced this pull request May 28, 2024
@ilya-lavrenov ilya-lavrenov deleted the jinja-installation-rules branch October 10, 2024 11:51
@ilya-lavrenov ilya-lavrenov restored the jinja-installation-rules branch October 10, 2024 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /