Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix problem with python version #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tduberne wants to merge 3 commits into jgoerner:master
base: master
Choose a base branch
Loading
from tduberne:master

Conversation

@tduberne
Copy link

@tduberne tduberne commented Aug 2, 2018

numpy failed to compile using the "latest" version from python:3
using python:3.6 fixes the issue

issue remains if using python:3.7

I did this fix for myself, and thought you might be interested in merging it back on your side (or find a solution you find more suitable ;-))

jgoerner reacted with thumbs up emoji
Copy link

Especially the makefile is useful! Thx @tduberne Is numpy still not compiling under 3.7?

Copy link
Owner

Thanks @tduberne for your support - the Makefile is indeed a helpful tool
As asked by @plattenschieber, do you still encouter problems with the numpy compilation?

I will take a look at your PR as well as #2 and merge them ASAP.

Copy link
Owner

Hey @tduberne

Sorry for coming back so lately. As I seem to already changed the Python version in a previous commit that topic should be fixed - however I really like your Makefile approach and would be happy to include it in the codebase.

Since you came up with that idea (and deserve the kudos) I would appreciate if you might open another PR based on the newest version of this repo - including the Makefile.

Would that be fine with you?

Copy link
Author

Sorry for the extremely late reply, this went buried in a massive amount of GitHub notifications...

No problem for the PR, I will do it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /