-
-
Couldn't load subscription status.
- Fork 81
Adding CSV reader. #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The key diff/improvement is now we add xpath to the csv reader so that we can perform both positive row selection as well as negative row skipping. Much more powerful than the old row skipping thingy. Next PR will bring the FileFormat implementation in, which will complete the csv fileformat.
Codecov Report
@@ Coverage Diff @@ ## master #82 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 33 35 +2 Lines 1476 1552 +76 ========================================= + Hits 1476 1552 +76
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The key diff/improvement is now we add xpath to the csv reader so that we can perform both positive row selection as well as negative row skipping. Much more powerful than the old row skipping thingy.
Next PR will bring the FileFormat implementation in, which will complete the csv fileformat.