-
-
Couldn't load subscription status.
- Fork 81
Add caching to custom_func javascript to boost perf (see benchmark results)
#67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@ ## master #67 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 29 29 Lines 1225 1257 +32 ========================================= + Hits 1225 1257 +32
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...oid unnecessary JSONify of contextual node which is pretty expensive; also address PR comment
@liangxibing @wangjia007bond any more comments? I did a split on javascript into javascript and javascript_with_context after PR approval. The rationale is: given javascript perf is good (with caching) so we can now deprecate eval; for vast majority use scenarios of eval and javascript, the node JSON serialization isn't needed thus why not save some time/resources and only do _node context when schema author chooses javascript_with_context. I also thought about doing some string/AST parsing to determine if the script contains reference to _node or not and auto choose node JSON serialization. But then I decided it's a bit too much over-engineering, just let schema author to choose.
No description provided.