-
-
Couldn't load subscription status.
- Fork 81
Adding flatfile.csv.reader implementation and tests; fix a bug in flatfile.fixedlength where column match goes wrong.
#178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...flatfile.fixedlength` where column match goes wrong.
The bug is in the `flatfile.fixedlength.reader.linesToNode`:
```
func (r *reader) linesToNode(decl *EnvelopeDecl, n int) *idr.Node {
if len(r.linesBuf) < n {
panic(
fmt.Sprintf("linesBuf has %d lines but requested %d lines to convert",
len(r.linesBuf), n))
}
node := idr.CreateNode(idr.ElementNode, decl.Name)
for col := range decl.Columns {
colDecl := decl.Columns[col]
for i := 0; i < n; i++ {
if !colDecl.lineMatch(i, r.linesBuf[i].b) {
continue
}
colNode := idr.CreateNode(idr.ElementNode, colDecl.Name)
idr.AddChild(node, colNode)
colVal := idr.CreateNode(idr.TextNode, colDecl.lineToColumnValue(r.linesBuf[i].b))
idr.AddChild(colNode, colVal)
break <==== PREVIOUSLY MISSED.
}
}
return node
}
```
v1.0.3 release missed the crucial `break` statement, thus for any multiple-line envelope (whether its rows based
or header/footer based), if there are multiple lines to match a column, always the last one wins. This is not
what our past expectation/specification was: the first line that matches should win.
Codecov Report
@@ Coverage Diff @@ ## master #178 +/- ## ========================================== Coverage 100.00% 100.00% ========================================== Files 51 52 +1 Lines 2836 2971 +135 ========================================== + Hits 2836 2971 +135
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug is in the
flatfile.fixedlength.reader.linesToNode:v1.0.3 release missed the crucial
breakstatement, thus for any multiple-line envelope (whether its rows based or header/footer based), if there are multiple lines to match a column, always the last one wins. This is not what our past expectation/specification was: the first line that matches should win. It's fixed now and tests have been amended to catch the issue.