-
-
Notifications
You must be signed in to change notification settings - Fork 81
Adding EDI file_declaration json schema
#103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The diffs from previous generation: - `fixed_length_in_bytes` is gone: in practice, never used it once. Why bother adding it here. - `release_character`'s `maxLength: 1` is gone: now our library code is more capable (and surprisingly much faster) to deal with esc whose len>1.
Codecov Report
Merging #103 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #103 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 37 37 Lines 1634 1634 ========================================= Hits 1634 1634
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update f71b49c...961247e. Read the comment docs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diffs from previous generation:
fixed_length_in_bytesis gone: in practice, never used it once. Why bother adding it here.release_character'smaxLength: 1is gone: now our library code is more capable (and surprisingly much faster) to deal with esc whose len>1.