Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: add setSerializers and defaultSerializers to TS types #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 1 commit into master from fix/ts
Nov 5, 2019

Conversation

@thymikee
Copy link
Member

@thymikee thymikee commented Nov 5, 2019

Adding missing TS types for setSerializers and defaultSerializers

cc @SimenB can you test that?

Copy link
Member

SimenB commented Nov 5, 2019

I'm unable to upgrade due to the changes in #92. That DefinitelyTyped/DefinitelyTyped#39243 was released is pretty weird to me, it's super breaking...

Anyway, the changes here looks great 👍

@thymikee thymikee changed the title (削除) fix: add setSerializers and defaultSerializers to TS types (削除ここまで) (追記) fix: add setSerializers and defaultSerializers to TS types (追記ここまで) Nov 5, 2019
@thymikee thymikee merged commit 992a35c into master Nov 5, 2019
@thymikee thymikee deleted the fix/ts branch November 5, 2019 09:55
Copy link
Member Author

thymikee commented Nov 5, 2019

Is it possible for TS to override the interface to be compatible with the older version of @types/jest? If not, please let me know if you have ideas on how we could support both interfaces for Matchers

Copy link
Member

SimenB commented Nov 5, 2019

I don't know... IMO @types/jest should be reverted, it's way too breaking. But I haven't really looked into it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /