-
Notifications
You must be signed in to change notification settings - Fork 23
chore: migrate to typescript #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
breaking change, btw
ea46859 to
6b2f50d
Compare
Tested globals extending jest object on a sample project with snapshot-diff linked and it didn't work. I wonder how would it work if root index.d.ts is not referenced by tsconfig nor package.json now. I tried moving namespace declaration to build/index.d.ts directly and it doesn't make a difference. I'm out of ideas for now :D
b307c24 to
e738d9b
Compare
Just leaving this here for future reference :P https://github.com/facebook/jest/pull/13195/files
Why not 😀
I have no idea if the global types still work. They should.