fix: invalid cookie parsing for the "=" character #271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

naorpeled merged 1 commit into jeremydaly:main from qgolsteyn:main

Jun 9, 2024

Merged

fix: invalid cookie parsing for the "=" character #271

naorpeled merged 1 commit into jeremydaly:main from qgolsteyn:main

Jun 9, 2024

Conversation

@qgolsteyn

Copy link

Contributor

@qgolsteyn qgolsteyn commented Jun 9, 2024 •

edited

Loading

Change:

Addresses the invalid cookie parse when the cookie value contains a "=".
Add a test to ensure the cookie parsing logic supports the entire ASCII character set, minus semi-colon, comma, backslash, percent, and white space.

Closes #269

Note:
I stumbled on another issue regarding cookie parsing while working on this PR. I opened an issue here: #270

@naorpeled

Copy link

Collaborator

naorpeled commented Jun 9, 2024

Hey,
first of all thanks! You're AWSome.

I'll give the issue you've raised some thought.
Regarding the tests that are failing in Node 14, if there's an easy fix let's implement it. Otherwise, we might just drop Node 14 support as it already reached its EOL