-
Notifications
You must be signed in to change notification settings - Fork 7
Sync with upstream @ 47d18659 #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changes to Summary description of `clientLeft/clientTop`. I **think** this is what was meant.
added a missing word
The solution explanation is not very obvious so added another example to make things clear
quick description: before: .catch(f) is the same as promise.then(null, f) after: .catch(f) is the same as .then(null, f)
Changed the reference to each item of the array since it was previously defined as the variable word.
When assigning the static method `staticMethod` to the `User` class, as a property directly, no parentheses should be used after `User`, since this leads to an error: `SyntaxError: Unexpected token '('`. For this reason, such parentheses have to be removed.
in the control control forms section, fixed mistake selectionEnd and selectionStart were both said to be start position
Removed duplicated `also`.
Fix: typos in <5-network/02-formdata/article.md>
Fix err in syntax
Update article.md
fixed a word 'operational' to be 'operating'
typo
Update article.md
replace russian-english comment with english
modified a sentence
'and want' to implement...
Update 'Window sizes and scrolling' article.md
Consistent HTML for the task source and solution
consistent CSS for the task and the solution
Update solution.md
add consistency
Fix small grammar mistake in closure makeArmy task
BigInt Type added in primitive types
Update master
Grammar and phrasing changes to first paragraph. Not 100% sure didn't change meaning so am leaving it for review.
Grammar and phrasing changes to first paragraph. Wasn't 100% sure didn't change meaning and was going to leave it for review, but it seems I already committed it somehow when I was trying to make revisions, so hope it's right.
Fix small typo in comment
Add a missing word
Update article.md
consistent error output comments
Added clarification
CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 15 committers have signed the CLA.
✅ iliakan
❌ spaceinvadev
❌ dashaezhova
❌ paroche
❌ jakewilson
❌ odv
❌ huyenltnguyen
❌ ajitsinghkaler
❌ masterashu
❌ Haggr
❌ kvoncode
❌ lex111
❌ koala-lava
❌ dagolinuxoid
❌ generally23
You have signed the CLA already but the status is still pending? Let us recheck it.
This PR was automatically generated to merge changes from en.javascript.info at 47d1865
Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.
Alternatively, you can close this PR and merge conflicting changes manually.
The following files have conflicts and may need updates of the translations:
To merge changes manually (instead of merging this PR):
git add remote upstream https://github.com/javascript-tutorial/en.javascript.infogit checkout mastergit pull upstream mastergit checkout --ours <path>git diff --word-diff master...upstream/master <path>(please note: three dots in the command)git push origin masterThis PR will be closed and replaced with a new one in a few days.