-
Notifications
You must be signed in to change notification settings - Fork 7
Sync with upstream @ b52aa942 #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- fix erratas - fix wrong error message - add 'run' on runnable example - add explanation about window.onload property corresponding load event - add comment about window.onstorage property corresponding storage event
Copy and paste mistake
small typo fix
Add commas after non-terminal properties
func.apply(context, args); // is same as using apply => Is a type error?
Comments section: Remove useless spaces
fix: removed , from solution.md and task.md for date data types
Corrected Grammar
fix: 2 stray lines of russian and a typo
fix: fix markdown highlight
Fix minor type error
Fix for Issue #1866
google js guide link
The english websocket article was missing an "in". I fixed it for you. :)
Just a simple check to see if the code works on the example given in the task.
remove a stray 's' that caused an error in ball drag example
On task.md, " -9 " has 2 white spaces before "-9".
The phrase `zero becames 100.` make me think that there is a variable `zero` defined when there is not.
Update phrasing on "Comparison with ||"
fixed wrong formatting
Grammar fix: Missing "is" in websocket EN article
Add test cases for 1-js/06-advanced-functions/03-closure/9-sort-by-field
Match the solution with the question on "Type conversions" task
Grammar and typo fix in pointer events
CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 14 committers have signed the CLA.
✅ iliakan
✅ tmollov
❌ GabrieleC
❌ ekira
❌ ironsoul0
❌ kumarvaibhav45
❌ lex111
❌ damage92
❌ tiagocastro070
❌ michaelborn
❌ dharohar-rathore
❌ syncopika
❌ diegotc86
❌ Logan-Schelly
You have signed the CLA already but the status is still pending? Let us recheck it.
This PR was automatically generated to merge changes from en.javascript.info at b52aa94
Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.
Alternatively, you can close this PR and merge conflicting changes manually.
The following files have conflicts and may need updates of the translations:
To merge changes manually (instead of merging this PR):
git add remote upstream https://github.com/javascript-tutorial/en.javascript.infogit checkout mastergit pull upstream mastergit checkout --ours <path>git diff --word-diff master...upstream/master <path>(please note: three dots in the command)git push origin masterThis PR will be closed and replaced with a new one in a few days.