-
Notifications
You must be signed in to change notification settings - Fork 7
Sync with upstream @ c89ddc5d #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixed typo in article.md
Function return example update
Typo fix.
Make minor grammar corrections/updates to async/microtask-queue
Update 'Selection and Range' article.md
A small grammar change and fixing a typo (I think) (no -> not).
Actually taking out a comma.
Make minor grammar corrections/updates to async/promise-basics
Change panel names according to official documentation
Translated tasks to English Language.
Edit sentance syntax in closure article
"sum(1)" doesn't return a wrapper, "curriedSum(1)" does.
I think this is the way it is typically used here and elsewhere. reserving "brackets" without a qualifier for indicating square brackets., so probably no explanation is necessary.
But, for those who want to know more:
It does seem to be the case that in British English "brackets" typically means "round brackets", which are parentheses, but in American English "brackets" typically means square brackets ("[]").
Admittedly, "brackets" is easier to spell. And to pronounce. Even to type, once you get used to it.
Again, in American English, and programming, "brackets" usually means "square brackets". "Parentheses" is unambiguous.
Object.assign() is referring to wrong article, which is Sympol. so I fix it to the right article "objects" with the right section #Cloning and merging, Object.assign
Fix minor type error
fix an anchor link error
Fix minor type error
Fixing "sum(1)" instead of "curriedSum(1)" (l. 42)
fix missing js formatting
Add bigint to 1-js/02-first-steps/17-javascript-specials/article.md
"synctax" to "syntax"
Change switch Grouping of "case" example
Change switch Grouping of "case" example
fix minor typo
Either quotation marks or italicization
CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
5 out of 10 committers have signed the CLA.
✅ leviding
✅ KennethKinLum
✅ Aakodal
✅ iliakan
✅ SambaLim
❌ wonderingabout
❌ paroche
❌ baooab
❌ lex111
❌ Ahmed-Magdy-S
You have signed the CLA already but the status is still pending? Let us recheck it.
This PR was automatically generated to merge changes from en.javascript.info at c89ddc5
Conflicted files in this PR have labels ">>>..." with both sides of conflict. If you merge this PR, you'll need to examine the listed files and resolve conflicts.
Alternatively, you can close this PR and merge conflicting changes manually.
The following files have conflicts and may need updates of the translations:
To merge changes manually (instead of merging this PR):
git add remote upstream https://github.com/javascript-tutorial/en.javascript.infogit checkout mastergit pull upstream mastergit checkout --ours <path>git diff --word-diff master...upstream/master <path>(please note: three dots in the command)git push origin masterThis PR will be closed and replaced with a new one in a few days.