-
Notifications
You must be signed in to change notification settings - Fork 69
Renders inner NotionCallout content #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.
🔍 Inspect: https://vercel.com/janniks/vue-notion/EWHE5SxxgE5Vtykq5LGAVhJjAScn
✅ Preview: https://vue-notion-git-fork-eliasparis-improve-callouts-janniks.vercel.app
blombard
commented
Apr 11, 2025
I think we can close this PR since it has been done here: e101bde
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @janniks hope you are doing good!
It looks like notion allows to include any kind of content within the Callout block. So you can have infinite nested content in them. I just opened a
<slot />within the NotionCallout component so it keep rendering the blocks.Now we are capable to render the following blockMap:
Captura de pantalla 2022年04月11日 a las 14 14 07
Thanks for your awesome block!