-
Notifications
You must be signed in to change notification settings - Fork 91
add a new option to json_file constructor #566
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If nullify_pointer is False, the pointer is not nullified Fixes #564
LaplaceSoda
commented
Jun 2, 2024
Test results show that after adding nullify_pointer=.false., the original json_file object seems still broken.
Yeah, this doesn't really "fix" the issue you mention in #564, but it just gives another option for something somebody might want to do in some cases. Specifically, add a json pointer to a json_file, but keeping it associated, and then subsequently nullifying the one in the json_file.
...into 564-nullify-option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If nullify_pointer is False, the pointer is not nullified
Fixes #564