Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add cli for creating controllers and middlewares #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
elliot-ghorbani wants to merge 1 commit into izniburak:master from elliot-ghorbani:master

Conversation

@elliot-ghorbani
Copy link

@elliot-ghorbani elliot-ghorbani commented Sep 3, 2020

No description provided.

Copy link
Contributor

@peter279k peter279k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you try to resolve issue #36?

And I think this approach is not good because it's native CLI and we cannot verify every command works.

I prefer using the symfony/console to create related console :).

izniburak and elliot-ghorbani reacted with thumbs up emoji
Copy link
Owner

Hi @41i-6h0rb4n1 ,
Firstly, Thank you for your support and effort.
I agree with @peter279k . I think, we can use symfony/console package as a development dependency in order to make mini console app for this project. I consider that we can work on this PR. Actually, I was working on a feature like that, but I couldn't complete yet due to busy. We can go over the this console application idea.

peter279k and elliot-ghorbani reacted with thumbs up emoji

Copy link
Contributor

Hi @41i-6h0rb4n1 ,
Firstly, Thank you for your support and effort.
I agree with @peter279k . I think, we can use symfony/console package as a development dependency in order to make mini console app for this project. I consider that we can work on this PR. Actually, I was working on a feature like that, but I couldn't complete yet due to busy. We can go over the this console application idea.

Thanks for your reply, @izniburak. I think you can close PR and create your PR that your console :).

Copy link
Author

Hi guys.
Thanks for your answers.

So I will try symfony/console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@peter279k peter279k peter279k left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /