-
Notifications
You must be signed in to change notification settings - Fork 70
Expose actionStream in Notifier Service #214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dominique-mueller can you please review?
Codecov Report
@@ Coverage Diff @@ ## develop #214 +/- ## ======================================== Coverage 99.11% 99.12% ======================================== Files 14 14 Lines 454 456 +2 Branches 76 76 ======================================== + Hits 450 452 +2 Misses 4 4
|
itsdevdom
itsdevdom
approved these changes
Jul 13, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@itsdevdom
itsdevdom
changed the title
(削除) add observable actionStream (削除ここまで)
(追記) Expose actionStream in Notifier Service (追記ここまで)
Jul 13, 2021
Released with 9.1.0.
fast-facts
referenced
this pull request
in fast-facts/angular-notifier
Jun 17, 2022
Co-authored-by: SZolin <SZolin@stream.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the package.
I would like to listen to the actions.
This will help me enable my handlers, such as playing sounds when a certain notification appears or finding out that the user has closed the notification without creating a custom template for notifications.