-
Notifications
You must be signed in to change notification settings - Fork 13.4k
fix(core): add an export map to import individual components #29717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks @sean-perkins for the feedback, I applied suggested improvements.
@christian-bromann it looks like the docs.json still needs to be added to the package.json exports to resolve the Vue related build issues.
For the angular build issues/test issues, you should see this error:
Error: Module not found: Error: Package path ./loader
we should export the loader path as well for the lazy loaded distribution.
f95bf0f to
47b4a0c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 👍
We should definitely get someone from the Ionic Framework team to look at this for visibility to the change/impacts.
There is some risk that we are missing exporting an obscure build file that is not leveraged in Ionic Framework's packages/test apps, but a developer is making use of. I still think we could publish this as a patch or minor and if those cases are reported, we add the missing exports paths/evaluate what files are being consumed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the reason for not including ion-action-sheet, ion-alert, and others that are missing?
(削除) Will this also fix the described code-splitting issue here #28574 ? Sounds like with that change I am able to just use a component from one exported path instead of just @ionic/angular/standalone, right? (削除ここまで)
ok nvm I just tested removing fesm and export datetime explictly it does not change the build outcome or put datetime in a separate chunk file, guess its up to the bundlers... looking at you rspack.
@christian-bromann what's the status of this PR?
Uh oh!
There was an error while loading. Please reload this page.
What is the current behavior?
The core package doesn't provide an export map, which prevents modern code bases to import specific components.
fixes #29716
What is the new behavior?
This patch contains:
nodetobundlerin the `moduleResolution field, both resolutions are very similar - changing this has no impact on the user as it is only for internal developmentDoes this introduce a breaking change?
This should not impact users at all but enable them to use a different module resolution. However, I may not be too familiar how Ionic components are imported, therefor it would be good to do some thorough testing.
Other information
n/a