-
Notifications
You must be signed in to change notification settings - Fork 23
Add rule for space after cast and space after Not #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
There will be a lot of fun.
@antonioeatgoat Thank you for the PR.
Can we split the space after the cast from the space after the "not" operator?
@gmazzap done 👍
gmazzap
gmazzap
approved these changes
Nov 17, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
New feature.
What is the current behavior?
There are no checks on spaces after cast or spaces after Not operator. All the following lines pass the test:
(string) $variable(string)$variable$variable = !$variable$variable = ! $variableif (!$variable)if (! $variable)What is the new behavior?
The space after cast and Not operator is mandatory. These are the only accepted cases:
(string) $variable$variable = ! $variableif (! $variable)Does this PR introduce a breaking change?
No
Other information:
Both of the changes are addressable by
phpcbfscript.