Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Modernize ancient PSR coding style #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
szepeviktor wants to merge 1 commit into inpsyde:master from szepeviktor:patch-1
Closed

Modernize ancient PSR coding style #30

szepeviktor wants to merge 1 commit into inpsyde:master from szepeviktor:patch-1

Conversation

@szepeviktor
Copy link

@szepeviktor szepeviktor commented Nov 23, 2019

Copy link
Contributor

gmazzap commented Mar 18, 2020

Thanks @szepeviktor

I agree with this and I think "officially" embracing PSR-12 is desired at this point. But because this are Inpsyde's code style this is not a decision I can make for the company.

So I can't merge this by myself.

Will ask other devs at Inpsyde for their opinion and merge if majority of them agree.

Copy link
Author

Copy link
Contributor

gmazzap commented Mar 31, 2020

Thanks @szepeviktor this has been approved unanimously but what's in the PR is not enough to switch to PSR-12.

The modernization is now handled in #35

Thanks!
szepeviktor reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmazzap gmazzap gmazzap approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /