-
Notifications
You must be signed in to change notification settings - Fork 53
Add ReactStringReplace Component #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
hey thanks for this @DerGoogler. Changing the default export is bound to cause breakage, but could release this as v2.
If you add some testing for the new component to test.js I'd be happy to incorporate this. Also that will make sure the existing tests still run, since they use the default export.
(not to self, should add an action to run the tests for PRs)
I know this is a bad idea, this would break many libraries and app when update their dependencies..
dzikoysk
commented
May 30, 2023
Is there any chance to get v2 with this change?
Uh oh!
There was an error while loading. Please reload this page.
Here is an example how it could works