-
Notifications
You must be signed in to change notification settings - Fork 18
Disallow use function and use const
#188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jrfnl
commented
Apr 7, 2020
Special thanks to @jrfnl for building this ruleset for us and making this so easy to use!
Well, didn't build it just for you, but glad you like it. ;-)
use function (削除ここまで)use function and use const (追記ここまで)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these changes intentional? Neither of them will have any effect if the project isn't the root project.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They were, yes. phpcsextra is only released as alpha and it wouldn't install without adding these in: https://github.com/PHPCSStandards/PHPCSExtra/releases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, we'll have to hold on releasing this then until phpcsextra is released, as the minimum-stability won't flow through, and would make the coding standards uninstallable as a dependency.
Requested a stable release: PHPCSStandards/PHPCSExtra#91
This addition disallows developers from using functions, while keeping the ability to
usenamespaces and constants.Special thanks to @jrfnl for building this ruleset for us and making this so easy to use!