Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

flash-attn2: [XPU] Fix the transformers UT bugs #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
YangKai0616 wants to merge 8 commits into huggingface:main from YangKai0616:main

Conversation

@YangKai0616
Copy link
Contributor

@YangKai0616 YangKai0616 commented Oct 30, 2025

This PR resolves some bugs encountered when integrating XPU flash-attn2 into transformers:

  1. Add regular parameter check;
  2. Fix the issue of inconsistency between input tensor and kernel workspace when using multiple XPUs;
  3. Make the return value continuous.

@YangKai0616 YangKai0616 changed the title (削除) [XPU] Fix the transformers UT bugs (削除ここまで) (追記) flash-attn2: [XPU] Fix the transformers UT bugs (追記ここまで) Oct 30, 2025
@YangKai0616 YangKai0616 marked this pull request as ready for review October 31, 2025 02:34
Copy link
Contributor Author

@drbh , I can compile this PR successfully using the local nix. please help review. Thanks!

drbh reacted with eyes emoji

Copy link
Member

danieldk commented Nov 3, 2025

CI running in #61

Copy link
Member

danieldk commented Nov 4, 2025

Merged in #61.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@drbh drbh Awaiting requested review from drbh drbh is a code owner

@MekkCyber MekkCyber Awaiting requested review from MekkCyber MekkCyber is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /