-
Notifications
You must be signed in to change notification settings - Fork 3k
feat(load): fallback to load_from_disk() when loading a saved dataset directory
#7653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...`load_dataset` ### Related Issue Fixes huggingface#7503 ### What does this PR do? This PR introduces a fallback mechanism in `load_dataset()` that detects when the input `path` points to a dataset previously saved using `save_to_disk()`, and automatically redirects to `load_from_disk(path)`. Previously, calling `load_dataset("/path/to/saved/dataset")` would misinterpret the local structure and return incorrect metadata rows. Now: ```python # Before: unexpected result ds = load_dataset("my_saved_dataset") # Misinterprets metadata # After: correct behavior ds = load_dataset("my_saved_dataset") # Auto-switches to load_from_disk()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Fixes #7503
Partially addresses #5044 by allowing
load_dataset()to auto-detect and gracefully delegate toload_from_disk()for locally saved datasets.What does this PR do?
This PR introduces a minimal fallback mechanism in
load_dataset()that detects when the providedpathpoints to a dataset saved usingsave_to_disk(), and automatically redirects toload_from_disk().🐛 Before (unexpected metadata-only rows):
✅ After (graceful fallback):
Why is this useful?
save_to_disk().lighteval) that rely onload_dataset()calls.