-
Notifications
You must be signed in to change notification settings - Fork 1.6k
[TRANSLATION] add japanese version for unit0/1 & communication #567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@sergiopaniego Hi, could someone review this PR?
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for adding the translation!
Would it be possible to include Unit 1 in the translation as well and merge everything together? I think that would really add a lot of value to it! 😄
@sergiopaniego I'd be happy to help as a reviewer for this language if needed. Let me know if I can assist.
@sergiopaniego I'd be happy to help as a reviewer for this language if needed. Let me know if I can assist.
Sure @yuka-with-data, that would be super cool! Could you review the current materials? 😄 Additionally, once Unit 1 is completed, @ktro2828 could also ping both of us to review the complete materials
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
Signed-off-by: ktro2828 <kotaro.uetake@tier4.jp>
5bdec10 to
3699708
Compare
Uh oh!
There was an error while loading. Please reload this page.
What
Hi, thank you for providing great course!
In this PR, I added Japanese version for unit0.