-
-
Notifications
You must be signed in to change notification settings - Fork 8
Fix loader syntax in README #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Merging #8 into master will not change coverage.
The diff coverage isn/a.
@@ Coverage Diff @@ ## master #8 +/- ## ======================================= Coverage 88.05% 88.05% ======================================= Files 1 1 Lines 67 67 ======================================= Hits 59 59 Misses 8 8
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered by Codecov. Last update e66e738...4909bfa. Read the comment docs.
Nice one, thanks Jay! 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Howdy again from the states!)
An issue I ran into while migrating my projects to Webpack 2 is that it does not auto-append
-loaderto the loader's name as Webpack 1 did. This means that Webpack will try to loadhtmlhintitself from node_modules as the loader instead ofhtmlhint-loader, giving off an error message like:I tested that the syntax
loader: 'htmlhint-loader'works just the same on Webpack 1.6 as it does Webpack 2.4, so I think the readme example should reflect that. Let me know if I am missing something, and thanks for one of your many great tools!