-
Couldn't load subscription status.
- Fork 43
Fix compile errors #844
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compile errors #844
Conversation
Add missing #include <algorithm> for std::any_of() and std::count_if()
Codecov Report
@@ Coverage Diff @@ ## master #844 +/- ## ====================================== Coverage 78.6% 78.7% ====================================== Files 292 292 Lines 9951 9951 ====================================== + Hits 7824 7827 +3 + Misses 2127 2124 -3
Continue to review full report at Codecov.
|
Add missing #include for std::find_if()
Add missing #include for std::find() usage
Add #include for std:find()
Add missing #include for std::transform()
add missing include
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing to our repo!
You need to add DCO to your commit message and the commit message needs to have the following structure:
Summarize changes in around 50 characters or less.
Mandatory detailed explanatory text. Wrap it to about 72
characters or so. In some contexts, the first line is treated as the
subject of the commit and the rest of the text as the body. The
blank line separating the summary from the body is critical (unless
you omit the body entirely); various tools like `log`, `shortlog`
and `rebase` can get confused if you run the two together.
Explain the problem that this commit is solving. Focus on why you
are making this change as opposed to how (the code explains that).
Are there side effects or other unintuitive consequences of this
change? Here's the place to explain them.
Optional further paragraphs come after blank lines.
- Bullet points are okay, too.
- Typically a hyphen or asterisk is used for the bullet, preceded
by a single space, with blank lines in between, but conventions
vary here.
All commits need to reference a ticket, again separated by a blank
line from the commit message summary above:
Resolves: ABC-111, #123
Relates-To: ABC-333, #321
See also: ABC-432, #456, #789
Signed-off-by: FirstName LastName <firstname.lastname@here.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move up between own header and module headers.
See coding style guide -> https://google.github.io/styleguide/cppguide.html#Names_and_Order_of_Includes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add missing #include for std::any_of() and std::count_if()