Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

refactor: use standard rpc style #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
setcy merged 31 commits into main from dev-standard-rpc
Jul 8, 2022
Merged

refactor: use standard rpc style #9

setcy merged 31 commits into main from dev-standard-rpc
Jul 8, 2022

Conversation

@fdkevin0
Copy link
Contributor

@fdkevin0 fdkevin0 commented Jun 5, 2022
edited by setcy
Loading

@fdkevin0 fdkevin0 changed the title (削除) refactor: use standard rock (削除ここまで) (追記) refactor: use standard rpc style (追記ここまで) Jun 5, 2022
@fdkevin0 fdkevin0 self-assigned this Jun 5, 2022
# Conflicts:
#	docs/swagger/campusapis/health/v1/health.swagger.json
#	docs/swagger/consultingapis/faq/v1/faq.swagger.json
Copy link
Member

setcy commented Jun 25, 2022

打算什么时候合并

Copy link
Contributor Author

需要所有相关依赖服务都迁移至新的proto定义且完成测试
该pr需要code review

setcy and others added 19 commits June 28, 2022 14:50
# Conflicts:
#	campusapis/staff/v1/campus.pb.go
#	campusapis/staff/v1/campus.pb.gw.go
#	campusapis/staff/v1/campus.proto
#	campusapis/staff/v1/campus_grpc.pb.go
#	docs/swagger/campusapis/staff/v1/campus.swagger.json
# Conflicts:
#	aggregatingapis/infostream/v1/infostream.pb.go
Copy link
Member

setcy commented Jun 30, 2022

@fdkevin0 给前端的数据多包了一层怎么处理,是在gateway之类的地方把外壳脱了还是直接让前端改

Copy link
Contributor Author

fdkevin0 commented Jul 1, 2022

@fdkevin0 给前端的数据多包了一层怎么处理,是在gateway之类的地方把外壳脱了还是直接让前端改

什么叫多包了一层,给一个样例
之前我是在salmon_basegrpc_gateway中劫持http返回体,然后强行包一层的,这会导致rpc定义与实际不符
在新分支内我已经改用proto定义返回体最外层,然后使用grpc中间件劫持error并注入grpc返回体最外层

Copy link
Member

setcy commented Jul 1, 2022

什么叫多包了一层,给一个样例
之前我是在salmon_basegrpc_gateway中劫持http返回体,然后强行包一层的,这会导致rpc定义与实际不符
在新分支内我已经改用proto定义返回体最外层,然后使用grpc中间件劫持error并注入grpc返回体最外层

哦哦懂了,之前理解错了

setcy added 2 commits July 5, 2022 16:40
# Conflicts:
#	campusapis/staff/v1/campus.pb.go
#	docs/swagger/campusapis/staff/v1/campus.swagger.json
@setcy setcy requested review from aFlyBird0 and iyear July 8, 2022 01:53
Copy link
Member

iyear commented Jul 8, 2022

有亿点review不动😥

@setcy setcy merged commit 7f74919 into main Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aFlyBird0 aFlyBird0 Awaiting requested review from aFlyBird0

@iyear iyear Awaiting requested review from iyear

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /