Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Helm vault namespace do not set if empty #1036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
owenhaynes wants to merge 1 commit into hashicorp:main
base: main
Choose a base branch
Loading
from owenhaynes:helm-fix-vaultauth-namespace

Conversation

@owenhaynes
Copy link

@owenhaynes owenhaynes commented Mar 21, 2025

When using server side diff with ArgoCD the default provided vault auths for both transit and the default fail to apply.

This is because they are set to null when rendered by ArgoCD because the value has not been quoted to take into account for empty strings.

ArgoCD will render the namespace as

namespace: null

which fails to apply because the CRD says it must be a string.

This fix drops the namespace if its not set, which will fix this error for people using argocd with server side diff

nut-api reacted with thumbs up emoji
When using server side diff with ArgoCD the default provided vault auths
for both transit and the default fail to apply.
This is because they are set to null when rendered by ArgoCD because the value has not been quoted to
take into account for empty strings.
ArgoCD will render the namespace as
```yaml
namespace: null
```
which fails to apply because the CRD says it must be a string.
This fix drops the namespace if its not set, which will fix this error
for people using argocd with server side diff
@owenhaynes owenhaynes requested a review from a team as a code owner March 21, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

AltStyle によって変換されたページ (->オリジナル) /