-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Cdn #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cdn #2
Conversation
Hello, very good to see you done this. I agreed with your point.
But if someone want to use this locally then will be a problem using cdn.
Is there any other choice can make?
But you are already using cdn, e.g.
https://github.com/jackycute/HackMD/blob/master/public/index.html#L18
So I don't think this is a new issue.
Produce a local version may be a possible solution.
Oh my, your totally right, I missed that...
OK, I will merge your PR, thank you very much.
I'm consider using requireJS to do cdn fallback now.
👍
Hello, I might fallback and not using cdn.
Because I found many people like to use this offline and internally, so it's better not use cdn.
Thank you anyway, and we might have a plan to make a standalone app in the future.
Maybe we can use a config to decide use it or use local files?
That's a good idea, I might will try it.
I've research again for cdn fallback, but no good solution for now.
Only can provide a config option to switch resource including templates.
Or use grunt or gulp to pack and compress things up to one might be better.
What do you think?
I think config is good enough 😄
Hey, I've add useCDN option, take a look!
👍
minor edit to dockerfile
To speed up and make the repo thinner, easier to manage.