Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Cdn #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jackycute merged 6 commits into hackmdio:master from PeterDaveHelloKitchen:cdn
Jul 2, 2015
Merged

Cdn #2

jackycute merged 6 commits into hackmdio:master from PeterDaveHelloKitchen:cdn
Jul 2, 2015

Conversation

@PeterDaveHello
Copy link
Contributor

@PeterDaveHello PeterDaveHello commented Jun 30, 2015

To speed up and make the repo thinner, easier to manage.

Copy link
Member

Hello, very good to see you done this. I agreed with your point.
But if someone want to use this locally then will be a problem using cdn.
Is there any other choice can make?

Copy link
Contributor Author

But you are already using cdn, e.g.
https://github.com/jackycute/HackMD/blob/master/public/index.html#L18

So I don't think this is a new issue.

Produce a local version may be a possible solution.

Copy link
Member

Oh my, your totally right, I missed that...
OK, I will merge your PR, thank you very much.

I'm consider using requireJS to do cdn fallback now.

jackycute added a commit that referenced this pull request Jul 2, 2015
@jackycute jackycute merged commit 4d40a10 into hackmdio:master Jul 2, 2015
Copy link
Contributor Author

👍

Copy link
Member

Hello, I might fallback and not using cdn.
Because I found many people like to use this offline and internally, so it's better not use cdn.
Thank you anyway, and we might have a plan to make a standalone app in the future.

Copy link
Contributor Author

Maybe we can use a config to decide use it or use local files?

Copy link
Member

That's a good idea, I might will try it.

I've research again for cdn fallback, but no good solution for now.
Only can provide a config option to switch resource including templates.
Or use grunt or gulp to pack and compress things up to one might be better.

What do you think?

Copy link
Contributor Author

I think config is good enough 😄

Copy link
Member

Hey, I've add useCDN option, take a look!

Copy link
Contributor Author

👍

lamprosfasoulas added a commit to lamprosfasoulas/codimd that referenced this pull request Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /