-
Notifications
You must be signed in to change notification settings - Fork 313
Add image filters #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
As mention in this issue I've added grayscale and other image filters
Checks are failing. Can you look what is wrong? Please also write unit test for new functions.
Apologies - was using PHP7 at home.
I'm not quite sure where to begin with the tests. Would I create images in the ressources and compare them?
Hi, Any update on this? Will you correct it?
Please check link for unit tests already written. You would ideally add one pre-processed image as string and then compare it with one unprocessed image processed by this library. This file has all tests written: https://github.com/eventviva/php-image-resize/blob/master/test/Test.php
Hi!
Any update on this?
It's pending because if unit tests.
Hello,
Sorry, I've not looked further into this - been slammed with work and personal projects.
I'm not quite sure how to make a pre-processed image as a string and still unsure how to write the tests for this. Any help would be hugely appreciated.
You can use fromstring and tostring methods of this library. Please check readme file and also check the test source code which can be found from above link I posted.
Hey, sorry for the delayed reply. I've tried and failed many times to pick this up and understand it but my brain just won't accept it.
If this is not a viable pull request - delete it and I'll use my own fork on my personal projects. Sorry to be a burden!
Thanks for the great package 😄
nanmu42
commented
Oct 26, 2017
Thanks for the effort anyway, dude. 👍
No description provided.