Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add image filters #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mikestreety wants to merge 3 commits into gumlet:master from mikestreety:master
Closed

Add image filters #90

mikestreety wants to merge 3 commits into gumlet:master from mikestreety:master

Conversation

@mikestreety
Copy link

@mikestreety mikestreety commented Aug 13, 2017

No description provided.

Copy link
Author

As mention in this issue I've added grayscale and other image filters

Copy link
Contributor

Checks are failing. Can you look what is wrong? Please also write unit test for new functions.

Copy link
Author

Apologies - was using PHP7 at home.

I'm not quite sure where to begin with the tests. Would I create images in the ressources and compare them?

Copy link
Contributor

Copy link
Contributor

Hi, Any update on this? Will you correct it?

Copy link
Author

mikestreety commented Sep 3, 2017 via email

No, sorry. I had a look and don't understand what I need to do.
...
On Sun, 3 Sep 2017 at 8:28 pm, Aditya Patadia ***@***.***> wrote: Hi, Any update on this? Will you correct it? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#90 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAVnJQmUha3aBiqWF8G0GGpInviQrSy1ks5sev3GgaJpZM4O1twb> .

Copy link
Contributor

Please check link for unit tests already written. You would ideally add one pre-processed image as string and then compare it with one unprocessed image processed by this library. This file has all tests written: https://github.com/eventviva/php-image-resize/blob/master/test/Test.php

Copy link
Contributor

Hi!
Any update on this?

Copy link
Contributor

adityapatadia commented Sep 10, 2017
edited
Loading

It's pending because if unit tests.

Copy link
Author

Hello,

Sorry, I've not looked further into this - been slammed with work and personal projects.

I'm not quite sure how to make a pre-processed image as a string and still unsure how to write the tests for this. Any help would be hugely appreciated.

Copy link
Contributor

You can use fromstring and tostring methods of this library. Please check readme file and also check the test source code which can be found from above link I posted.

Copy link
Author

Hey, sorry for the delayed reply. I've tried and failed many times to pick this up and understand it but my brain just won't accept it.

If this is not a viable pull request - delete it and I'll use my own fork on my personal projects. Sorry to be a burden!

Thanks for the great package 😄

Copy link

nanmu42 commented Oct 26, 2017

Thanks for the effort anyway, dude. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /