Skip to content

Resolves issue #136 #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

adityapatadia merged 1 commit into gumlet:master from peter279k:issue_#136

Jul 4, 2020

Merged

Resolves issue #136 #144

adityapatadia merged 1 commit into gumlet:master from peter279k:issue_#136

Jul 4, 2020

Conversation

Copy link

Contributor

@peter279k peter279k commented Jun 11, 2019

Changed log

Closes issue Recognize WEBP image format on php-5.x version #136 .
This Travis CI build will be failed due to undefined imagecreatefromwebp function.
And this has been mentioned on issue The Travis CI build will be failed because of undefined imagecreatefromwebp function #143 .
Once that issue is resolved, this Travis CI build will be successful, too.


 Resolves issue gumlet#136

652999c

peter279k commented

View reviewed changes

lib/ImageResize.php

throw new ImageResizeException('Could not read file');

}

list(

Copy link

Contributor Author

@peter279k peter279k Jun 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This syntax is unavailable in php-5.5 and php-5.6 versions.

Copy link

Contributor

adityapatadia commented Jul 31, 2019

I really don't think travis will resolve this very soon. Is there better way to make the tests pass?

@adityapatadia adityapatadia merged commit 63aea93 into gumlet:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment