-
Notifications
You must be signed in to change notification settings - Fork 312
added crop and updated your readme #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel namespaces are useful to prevent conflicts. Please add namespace and I will merge your PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Namespaces aren't supported in PHP less than 5.3. It seems the vast
majority of LAMP are legacy servers, especially with so many people using
MEAN and other stacks nowadays.
On Thu, Nov 14, 2013 at 3:38 PM, Aditya Patadia notifications@github.comwrote:
In src/ImageResize.php:
@@ -1,6 +1,6 @@
I feel namespaces are useful to prevent conflicts. Please add namespace
and I will merge your PR—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1/files#r7672627
.
added crop and updated your readme
added crop and updated your readme