-
Couldn't load subscription status.
- Fork 338
Laravel 9.x Compatibility #184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
phpunit/phpunit of ^9.3. If you would like to also upgrade your tests, you may run the PHPUnit 9 Shift for free.
⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.
To do so, temporarily add Shift's fork to the repositories property of your composer.json:
{
"repositories": [
{
"type": "vcs",
"url": "https://github.com/laravel-shift/laravel-mysql-spatial.git"
}
]
}Then update your dependency constraint to reference this branch:
{
"require": {
"grimzy/laravel-mysql-spatial": "dev-l9-compatibility",
}
}Finally, run: composer update
olipayne
commented
Feb 11, 2022
Also can confirm this is working as intended, would be nice to merge this ASAP.
mattvb91
commented
Mar 2, 2022
@grimzy any chance of getting this in? Thanks! 👍
@Zen0x7
Zen0x7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
mattvb91
commented
Mar 21, 2022
Does anyone have a maintained fork of this that I could switch to? Looks like this is is dead.
matthewheck17
commented
Mar 31, 2022
Is this going to get merged in anytime soon? @grimzy
Have a few projects I would love to update to Laravel 9. Is there something I/we can do to help git this committed @grimzy?
Also, for those needing to upgrade sooner than later, migrating to https://github.com/MatanYadaev/laravel-eloquent-spatial/ is relatively straight forward.
mattvb91
commented
Jun 21, 2022
@grimzy any chance of getting an ETA for this? I would prefer to stay with this but it looks like we need to migrate to another project
waustin
commented
Jun 30, 2022
Bump for getting this merged
expansive-pcseik
commented
Aug 18, 2022
Is there an ETA on merging this, or is it best to migrate to an alternate project / fork?
coronaJabu
commented
Aug 30, 2022
@olipayne @SpiritSaint FYI We are facing this issue too, please provide an ETA.
Also we are open to help if it is posible.
Looks like this could be an alternative: https://github.com/MatanYadaev/laravel-eloquent-spatial
The API seems to cover most of it but I havent had a chance yet to implement: https://github.com/MatanYadaev/laravel-eloquent-spatial/blob/master/API.md
If anyone gets a chance to switch please report back as this is dead
EDIT: just noticed @citricguy had already discovered it!
citricguy
commented
Sep 6, 2022
I wasn't doing anything too complex to begin with, however the switch to https://github.com/MatanYadaev/laravel-eloquent-spatial was very straight forward.
No issues upgrading to Laravel 9x after moving over.
matthewheck17
commented
Sep 6, 2022
I also ended up switching to https://github.com/MatanYadaev/laravel-eloquent-spatial and it wasn't too hard
tomavic
commented
Oct 6, 2022
@matthewheck17 @citricguy @mattvb91
I am trying it with a fresh new project with Laravel 9.x.
I will report here if that works fine.
QSoto
commented
Nov 2, 2022
The l9-compatibility was made to work with what MySql version? MySql 8?
mwargan
commented
Dec 5, 2022
After updating to this version, I get Incorrect parameter count in the call to native function 'ST_GeomFromText' when using distanceSphere()...
QSoto
commented
Dec 5, 2022
After updating to this version, I get
Incorrect parameter count in the call to native function 'ST_GeomFromText'when usingdistanceSphere()...
I faced the same issue. After long research, it looked like a MySQL 8 bug. I ended up using a plain distance calculation
joshbaumann
commented
Mar 6, 2023
For people trying to get this working with Laravel 10, I've created a fork with the dependencies bumped.
{
"repositories": [
{
"type": "vcs",
"url": "https://github.com/joshbaumann/laravel-mysql-spatial.git"
}
]
}
Then update your dependency constraint to reference this branch:
{
"require": {
"grimzy/laravel-mysql-spatial": "dev-l10-compatibility",
}
}
Finally, run: composer update
HiradRoshandel
commented
May 1, 2023
@grimzy would it be possible to get this in?
patrickomeara
commented
May 1, 2023
@aconital I highly recommend switching to https://github.com/MatanYadaev/laravel-eloquent-spatial
The switch was simple.
In my case it involved:
- switching to a new trait
- using the built in cast instead of
$spatialFields - using properties instead of methods ie
->latitudeinstead of->getLat()on the geo objects.
It took 20 minutes.
citricguy
commented
May 1, 2023
Same here, transition was quick and hasn't given me any issues at all.
HiradRoshandel
commented
May 1, 2023
@aconital I highly recommend switching to https://github.com/MatanYadaev/laravel-eloquent-spatial
The switch was simple.
In my case it involved:
- switching to a new trait
- using the built in cast instead of
$spatialFields- using properties instead of methods ie
->latitudeinstead of->getLat()on the geo objects.It took 20 minutes.
Thank you I'll give it a try
patrickomeara
commented
May 1, 2023
@citricguy thanks for the initial recommendation!
This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.
Before merging, you need to:
l9-compatibilitybranchIf you do find an issue, please report it by commenting on this PR to help improve future automation.