Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Laravel 9.x Compatibility #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laravel-shift wants to merge 1 commit into grimzy:master
base: master
Choose a base branch
Loading
from laravel-shift:l9-compatibility

Conversation

@laravel-shift
Copy link

@laravel-shift laravel-shift commented Feb 3, 2022

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 9.x.

Before merging, you need to:

  • Checkout the l9-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

clementmas, osteel, krenor, mziraki, lcabre, lloricode, waustin, d3radicated, sadekd, and Samuel-Webster reacted with thumbs up emoji clementmas, lorenzoaiello, osteel, nicogominet, Samuel-Webster, coronaJabu, d8vjork, itrack, and johnef reacted with eyes emoji
Copy link
Author

⚠️ The latest version of Laravel has a dependency for phpunit/phpunit of ^9.3. If you would like to also upgrade your tests, you may run the PHPUnit 9 Shift for free.

Copy link
Author

⚗️ Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
 "repositories": [
 {
 "type": "vcs",
 "url": "https://github.com/laravel-shift/laravel-mysql-spatial.git"
 }
 ]
}

Then update your dependency constraint to reference this branch:

{
 "require": {
 "grimzy/laravel-mysql-spatial": "dev-l9-compatibility",
 }
}

Finally, run: composer update

a-j-n, dominik-wbz, robindirksen1, bruce-atkinson, and well-place-dev2 reacted with thumbs up emoji sadekd, raoraafe, trippo, Surzhikov, a-j-n, robindirksen1, bruce-atkinson, well-place-dev2, and d8vjork reacted with heart emoji

Copy link

Also can confirm this is working as intended, would be nice to merge this ASAP.

clementmas, citricguy, FabienZE, vovarpd, lorenzoaiello, vesper8, ashwin-nath-m, mattvb91, nicogominet, bomshteyn, and 18 more reacted with thumbs up emoji olipayne and mattvb91 reacted with eyes emoji

Copy link

mattvb91 commented Mar 2, 2022

@grimzy any chance of getting this in? Thanks! 👍

Copy link

@Zen0x7 Zen0x7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

mattvb91 and Jul000 reacted with thumbs up emoji
Copy link

Does anyone have a maintained fork of this that I could switch to? Looks like this is is dead.

Copy link

Is this going to get merged in anytime soon? @grimzy

Copy link

citricguy commented Apr 5, 2022
edited
Loading

Have a few projects I would love to update to Laravel 9. Is there something I/we can do to help git this committed @grimzy?

Also, for those needing to upgrade sooner than later, migrating to https://github.com/MatanYadaev/laravel-eloquent-spatial/ is relatively straight forward.

aryehbeitz, waustin, mattvb91, and Blitheness reacted with thumbs up emoji

Copy link

@grimzy any chance of getting an ETA for this? I would prefer to stay with this but it looks like we need to migrate to another project

nicogominet, xyfantis, fransjooste1, and Samuel-Webster reacted with thumbs up emoji

Copy link

waustin commented Jun 30, 2022

Bump for getting this merged

lcabre, xewl, KurasovIvan, fransjooste1, belzaaron, Samuel-Webster, obayesshelton, coronaJabu, vansteen, and nouman-ashraf-awan reacted with thumbs up emoji

Copy link

Is there an ETA on merging this, or is it best to migrate to an alternate project / fork?

Samuel-Webster, obayesshelton, vansteen, and coronaJabu reacted with thumbs up emoji

Copy link

@olipayne @SpiritSaint FYI We are facing this issue too, please provide an ETA.
Also we are open to help if it is posible.

Copy link

mattvb91 commented Sep 6, 2022
edited
Loading

Looks like this could be an alternative: https://github.com/MatanYadaev/laravel-eloquent-spatial

The API seems to cover most of it but I havent had a chance yet to implement: https://github.com/MatanYadaev/laravel-eloquent-spatial/blob/master/API.md

If anyone gets a chance to switch please report back as this is dead

EDIT: just noticed @citricguy had already discovered it!

tomavic reacted with heart emoji

Copy link

I wasn't doing anything too complex to begin with, however the switch to https://github.com/MatanYadaev/laravel-eloquent-spatial was very straight forward.

No issues upgrading to Laravel 9x after moving over.

mattvb91, Blitheness, and jojomak13 reacted with thumbs up emoji

Copy link

I also ended up switching to https://github.com/MatanYadaev/laravel-eloquent-spatial and it wasn't too hard

mattvb91 reacted with thumbs up emoji

Copy link

tomavic commented Oct 6, 2022

@matthewheck17 @citricguy @mattvb91

I am trying it with a fresh new project with Laravel 9.x.

I will report here if that works fine.

Copy link

QSoto commented Nov 2, 2022

The l9-compatibility was made to work with what MySql version? MySql 8?

Copy link

mwargan commented Dec 5, 2022

After updating to this version, I get Incorrect parameter count in the call to native function 'ST_GeomFromText' when using distanceSphere()...

Copy link

QSoto commented Dec 5, 2022

After updating to this version, I get Incorrect parameter count in the call to native function 'ST_GeomFromText' when using distanceSphere()...

I faced the same issue. After long research, it looked like a MySQL 8 bug. I ended up using a plain distance calculation

mwargan reacted with thumbs up emoji

Copy link

For people trying to get this working with Laravel 10, I've created a fork with the dependencies bumped.

{
 "repositories": [
 {
 "type": "vcs",
 "url": "https://github.com/joshbaumann/laravel-mysql-spatial.git"
 }
 ]
}

Then update your dependency constraint to reference this branch:

{
 "require": {
 "grimzy/laravel-mysql-spatial": "dev-l10-compatibility",
 }
}

Finally, run: composer update

Copy link

@grimzy would it be possible to get this in?

Copy link

@aconital I highly recommend switching to https://github.com/MatanYadaev/laravel-eloquent-spatial

The switch was simple.

In my case it involved:

  • switching to a new trait
  • using the built in cast instead of $spatialFields
  • using properties instead of methods ie ->latitude instead of ->getLat() on the geo objects.

It took 20 minutes.

aanred reacted with thumbs up emoji

Copy link

Same here, transition was quick and hasn't given me any issues at all.

Copy link

@aconital I highly recommend switching to https://github.com/MatanYadaev/laravel-eloquent-spatial

The switch was simple.

In my case it involved:

  • switching to a new trait
  • using the built in cast instead of $spatialFields
  • using properties instead of methods ie ->latitude instead of ->getLat() on the geo objects.

It took 20 minutes.

Thank you I'll give it a try

Copy link

@citricguy thanks for the initial recommendation!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@olipayne olipayne olipayne approved these changes

@big-shadow big-shadow big-shadow approved these changes

@Zen0x7 Zen0x7 Zen0x7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AltStyle によって変換されたページ (->オリジナル) /